Patch for issue 2991165 - FreemarkerPageContext include troubles?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for issue 2991165 - FreemarkerPageContext include troubles?

Ronald Dehuysser
Hi Freemarker developers,

I just created a patch for the issue mentioned above. I wondered if any of you can review it and give me any feedback. It can be found here: http://sourceforge.net/tracker/?func=detail&aid=2992265&group_id=794&atid=100794

Looking forward to your feedback,
Ronald



------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
FreeMarker-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freemarker-devel
Reply | Threaded
Open this post in threaded view
|

Re: Patch for issue 2991165 - FreemarkerPageContext include troubles?

Attila Szegedi-3
Looking at it now.

Attila.

On 2010.08.05., at 11:30, Ronald Dehuysser wrote:

Hi Freemarker developers,

I just created a patch for the issue mentioned above. I wondered if any of you can review it and give me any feedback. It can be found here: http://sourceforge.net/tracker/?func=detail&aid=2992265&group_id=794&atid=100794

Looking forward to your feedback,
Ronald

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
FreeMarker-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freemarker-devel
Reply | Threaded
Open this post in threaded view
|

Re: Patch for issue 2991165 - FreemarkerPageContext include troubles?

Attila Szegedi-3
Here's a different patch - take a look. I'm not using SourceForge tracker as the SF.net site appears to be partially down...

It's similar to yours, except that it's writing directly to the underlying JspWriter, not buffering in an intermediate StringWriter. That's in line with the JSP spec for the method that says "The output of the target resources processing of the request is written directly to the current JspWriter returned by a call to getOut()."

Attila.




On 2010.08.05., at 22:52, Attila Szegedi wrote:

> Looking at it now.
>
> Attila.
>
> On 2010.08.05., at 11:30, Ronald Dehuysser wrote:
>
>> Hi Freemarker developers,
>>
>> I just created a patch for the issue mentioned above. I wondered if any of you can review it and give me any feedback. It can be found here: http://sourceforge.net/tracker/?func=detail&aid=2992265&group_id=794&atid=100794
>>
>> Looking forward to your feedback,
>> Ronald

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
FreeMarker-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freemarker-devel

jsp.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch for issue 2991165 - FreemarkerPageContext include troubles?

Ronald Dehuysser
Hi Attila,

I tested the patch and it works great! And, it's indeed better in line with the JSP spec.

So, how go things now? Will this be part of the next FreeMarker release? When is that one planned?

Thx for your help!
Ronald

On Thu, Aug 5, 2010 at 11:30 PM, Attila Szegedi <[hidden email]> wrote:
Here's a different patch - take a look. I'm not using SourceForge tracker as the SF.net site appears to be partially down...

It's similar to yours, except that it's writing directly to the underlying JspWriter, not buffering in an intermediate StringWriter. That's in line with the JSP spec for the method that says "The output of the target resources processing of the request is written directly to the current JspWriter returned by a call to getOut()."

Attila.




On 2010.08.05., at 22:52, Attila Szegedi wrote:

> Looking at it now.
>
> Attila.
>
> On 2010.08.05., at 11:30, Ronald Dehuysser wrote:
>
>> Hi Freemarker developers,
>>
>> I just created a patch for the issue mentioned above. I wondered if any of you can review it and give me any feedback. It can be found here: http://sourceforge.net/tracker/?func=detail&aid=2992265&group_id=794&atid=100794
>>
>> Looking forward to your feedback,
>> Ronald

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
FreeMarker-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freemarker-devel



------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
FreeMarker-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freemarker-devel
Reply | Threaded
Open this post in threaded view
|

Re: Patch for issue 2991165 - FreemarkerPageContext include troubles?

Daniel Dekany
Friday, August 6, 2010, 9:31:32 AM, Ronald Dehuysser wrote:

> Hi Attila,
>
> I tested the patch and it works great! And, it's indeed better in line with the JSP spec.
>
> So, how go things now? Will this be part of the next FreeMarker
> release? When is that one planned?

I'm pretty certain that before September there will be a 2.3.17.

> Thx for your help!
> Ronald
>
> On Thu, Aug 5, 2010 at 11:30 PM, Attila Szegedi <[hidden email]> wrote:
> Here's a different patch - take a look. I'm not using SourceForge
> tracker as the SF.net site appears to be partially down...
>
> It's similar to yours, except that it's writing directly to the
> underlying JspWriter, not buffering in an intermediate StringWriter.
> That's in line with the JSP spec for the method that says "The
> output of the target resources processing of the request is written
> directly to the current JspWriter returned by a call to getOut()."
>
> Attila.
>
>
>
>
> On 2010.08.05., at 22:52, Attila Szegedi wrote:
>
>> Looking at it now.
>>
>> Attila.
>>
>> On 2010.08.05., at 11:30, Ronald Dehuysser wrote:
>>
>>> Hi Freemarker developers,
>>>
>>> I just created a patch for the issue mentioned above. I wondered if any of you can review it and give me any feedback. It can be found here: http://sourceforge.net/tracker/?func=detail&aid=2992265&group_id=794&atid=100794
>>>
>>> Looking forward to your feedback,
>>> Ronald
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by
>
> Make an app they can't live without
> Enter the BlackBerry Developer Challenge
> http://p.sf.net/sfu/RIM-dev2dev 
> _______________________________________________
> FreeMarker-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/freemarker-devel
>

--
Best regards,
 Daniel Dekany


------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
FreeMarker-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/freemarker-devel